Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed laws for Bifunctor #557

Closed
agenovese opened this issue Oct 4, 2015 · 2 comments
Closed

Proposed laws for Bifunctor #557

agenovese opened this issue Oct 4, 2015 · 2 comments

Comments

@agenovese
Copy link

Currently there are no laws associated with Bifunctor, I'd like to propose the following:

Bifunctor Identity:

fa.bimap(identity, identity) <-> fa

Bifunctor Composition

fa.bimap(f1, f2).bimap(g1, g2) <-> fa.bimap(f1 andThen g1, f2 andThen g2)

@fthomas
Copy link
Member

fthomas commented Oct 4, 2015

See also #509. It is also good practice to add a comment here if you're working on this.

@fthomas
Copy link
Member

fthomas commented Oct 4, 2015

Fixed by #559

@fthomas fthomas closed this as completed Oct 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants