-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add some missing applicative and monad ops #1216
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package cats | ||
package syntax | ||
|
||
trait MonadSyntax { | ||
implicit def catsSyntaxMonadWhileM[F[_]: Monad, A](fa: F[A]): WhileMOps[F, A] = new WhileMOps(fa) | ||
implicit def catsSyntaxMonadUntilM[F[_]: Monad, A](fa: F[A]): UntilMOps[F, A] = new UntilMOps(fa) | ||
implicit def catsSyntaxMonadIterateWhile[F[_]: Monad, A](fa: F[A]): IterateWhileOps[F, A] = new IterateWhileOps(fa) | ||
implicit def catsSyntaxMonadIterateUntil[F[_]: Monad, A](fa: F[A]): IterateUntilOps[F, A] = new IterateUntilOps(fa) | ||
} | ||
|
||
final class WhileMOps[F[_], A](fa: F[A])(implicit M: Monad[F]) { | ||
def whileM[G[_]](p: F[Boolean])(implicit G: MonadCombine[G]): F[G[A]] = M.whileM(p)(fa) | ||
def whileM_[G[_]](p: F[Boolean])(implicit G: MonadCombine[G]): F[Unit] = M.whileM_(p)(fa) | ||
} | ||
|
||
final class UntilMOps[F[_], A](fa: F[A])(implicit M: Monad[F]) { | ||
def untilM[G[_]](p: F[Boolean])(implicit G: MonadCombine[G]): F[G[A]] = M.untilM(fa)(p) | ||
def untilM_[G[_]](p: F[Boolean])(implicit G: MonadCombine[G]): F[Unit] = M.untilM_(fa)(p) | ||
} | ||
|
||
final class IterateWhileOps[F[_], A](fa: F[A])(implicit M: Monad[F]) { | ||
def iterateWhile(p: A => Boolean): F[A] = M.iterateWhile(fa)(p) | ||
} | ||
|
||
final class IterateUntilOps[F[_], A](fa: F[A])(implicit M: Monad[F]) { | ||
def iterateUntil(p: A => Boolean): F[A] = M.iterateUntil(fa)(p) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the story on call-by-name vs
Eval[F[A]]
. Seems like the later is more the cats style (maybe have both, strict and Eval)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'll change those to strict +
Eval
. Honestly I have never had a case where it mattered, but scalaz does it this way so it's probably worthwhile to have the nonstrict version.