Make Bifoldable docs #4109
Make Bifoldable docs #4109
Conversation
|
@armanbilge here it is as promised in #4076 👍 |
gatear
force-pushed
the
bifoldable-docs
branch
from
dd8e3e3
to
b80e565
Compare
gatear
force-pushed
the
bifoldable-docs
branch
from
f5a9413
to
cb4d28d
Compare
gatear
force-pushed
the
bifoldable-docs
branch
from
c785cd8
to
be77729
Compare
gatear
force-pushed
the
bifoldable-docs
branch
from
d338e89
to
1f12f0c
Compare
|
@armanbilge I would say this version is final and ready for a re-review. Thanks! |
…tead of `Bifoldable`
| ```scala mdoc | ||
| case class Report(entries: List[String], errors: Int) { | ||
| def withEntries(entry: String): Report = | ||
| this.copy(entries = entries :+ entry) |
There was a problem hiding this comment.
appending to the right of a list is an anti-pattern (because it is O(N) and repeatedly doing it can create quadratic performance issues). Can we use Vector[String] or Chain[String] if you want to append?
There was a problem hiding this comment.
appending to the right of a list is an anti-pattern (because it is O(N) and repeatedly doing it can create quadratic performance issues). Can we use
Vector[String]orChain[String]if you want to append?
@johnynek I've switched to Chain[String]]
| def bifoldLeft[A, B, C](fab: F[A, B], c: C)(f: (C, A) => C, g: (C, B) => C): C | ||
|
|
||
| //lazily performs a right-associative bi-fold over `fab` | ||
| def bifoldRight[A, B, C](fab: F[A, B], c: Eval[C])(f: (A, Eval[C]) => Eval[C], g: (B, Eval[C]) => Eval[C]): Eval[C] |
There was a problem hiding this comment.
can we say any laws these must follow? You have a tuple example below which uses an ordering (left to right in your example), but would the other direction also be lawful?
|
@johnynek could you take a look? Not sure if I managed to address your comments. |
|
@gatear I'm sorry this has been sitting for so long, but I would like to merge it before our next release. Thanks again for your contribution. |
The first draft for
Bifunctordocs as required in #1801