Special case for parEvalMap with max concurrency of 1
#2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the penalty of using the combinator if there is no concurrency. Analogous to typelevel#2557 which did the same for `parJoin`.
bastewart
commented
Aug 27, 2021
| send = chan.send(value.get).as { | ||
| Stream.eval(f(o).attempt.flatMap(value.complete(_).void)) | ||
| )(f: O => F2[O2])(implicit F: Concurrent[F2]): Stream[F2, O2] = | ||
| if (maxConcurrent === 1) evalMap(f) |
There was a problem hiding this comment.
There is no direct assertion that maxConcurrent is > 0 in parEvalMap. There is an indirect on though as ultimately parEvalMap calls parJoin which does do this assertion.
Daenyth
approved these changes
Aug 27, 2021
|
@Daenyth sorry, not sure what to do here! Do I wait for another maintainer to give a second opinion and they'll potentially merge it? |
|
@bastewart Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the penalty of using the combinator if there is no
concurrency. Analogous to #2557 which did the same for
parJoin.