Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2717 #2745

Merged
merged 1 commit into from
Dec 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions core/shared/src/main/scala/fs2/internal/Scope.scala
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ import fs2.internal.InterruptContext.InterruptionOutcome
private[fs2] final class Scope[F[_]] private (
val id: Unique.Token,
private val parent: Option[Scope[F]],
interruptible: Option[InterruptContext[F]],
private val interruptible: Option[InterruptContext[F]],
private val state: Ref[F, Scope.State[F]]
)(implicit val F: Compiler.Target[F]) { self =>

Expand Down Expand Up @@ -276,6 +276,13 @@ private[fs2] final class Scope[F[_]] private (
case _: Scope.State.Closed[F] => F.pure(Right(()))
}

/** Like `openAncestor` but returns self if open. */
private def openScope: F[Scope[F]] =
state.get.flatMap {
case _: Scope.State.Open[F] => F.pure(self)
case _: Scope.State.Closed[F] => openAncestor
}

/** Returns closest open parent scope or root. */
def openAncestor: F[Scope[F]] =
self.parent.fold(F.pure(self)) { parent =>
Expand Down Expand Up @@ -412,13 +419,13 @@ private[fs2] final class Scope[F[_]] private (
iCtx.completeWhen(outcome)
}

/** Checks if current scope is interrupted.
/** Checks if the nearest open scope is interrupted.
* If yields to None, scope is not interrupted and evaluation may normally proceed.
* If yields to Some(Right(scope,next)) that yields to next `scope`, that has to be run and `next` stream
* If yields to Some(Right(scope,next)) that yields to next `scope`, that has to be run and `next` stream
* to evaluate
*/
def isInterrupted: F[Option[InterruptionOutcome]] =
interruptible match {
openScope.map(_.interruptible).flatMap {
case None => F.pure(None)
case Some(iCtx) => iCtx.ref.get
}
Expand Down
10 changes: 10 additions & 0 deletions core/shared/src/test/scala/fs2/StreamZipSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -416,5 +416,15 @@ class StreamZipSuite extends Fs2Suite {
.compile
.drain
}

test("#2717 - unexpected behavior of Pull") {
val stream = Stream(1).as(1).scope ++ Stream(2)
val zippedPull =
stream.pull.uncons1.flatMap { case Some((_, s)) =>
s.zipWith(Stream(3))((_, _)).pull.echo
}
val actual = zippedPull.stream.map(identity).covary[IO].compile.toList
actual.assertEquals(List((2, 3)))
}
}
}