return empty stream if topic is closed #3085
Conversation
| _ <- topic.subscribeUnbounded.compile.drain | ||
| } yield () | ||
|
|
||
| program.timeout(5.seconds) // will timeout if program is deadlocked |
There was a problem hiding this comment.
Instead of a timeout we should use executeEmbed.
https://github.com/typelevel/cats-effect/blob/8ba8916407eb8f35fbffae76f72dac48d2dc7357/testkit/shared/src/main/scala/cats/effect/testkit/TestControl.scala#L397-L416
There was a problem hiding this comment.
Ok thanks. executeEmbed does work. I tried execute with tickAll and isDeadlocked but that didn't work for me so I assumed executeEmbed would have the same problem, but apparently not... I'm probably misinterpreting what tickAll does then.
There was a problem hiding this comment.
isDeadlocked returns true if there is no more work scheduled.
https://github.com/typelevel/cats-effect/blob/8ba8916407eb8f35fbffae76f72dac48d2dc7357/testkit/shared/src/main/scala/cats/effect/testkit/TestControl.scala#L270-L276
However, this might be because the results are already available, which I believe is the case here.
https://github.com/typelevel/cats-effect/blob/8ba8916407eb8f35fbffae76f72dac48d2dc7357/testkit/shared/src/main/scala/cats/effect/testkit/TestControl.scala#L127
I wonder if isDeadlocked should check that as well.
| program.timeout(5.seconds) // will timeout if program is deadlocked | ||
| TestControl.executeEmbed(program) |
There was a problem hiding this comment.
Thanks! I think the comment about testing for deadlock is still helpful.
Closes #3083.