Fix interop.reactivestreams.StreamUnicastPublisher #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalmungSan
force-pushed
the
improve-reactive-streams
branch
from
76632a4
to
7a33776
Compare
BalmungSan
force-pushed
the
improve-reactive-streams
branch
from
7a33776
to
7695889
Compare
BalmungSan
force-pushed
the
improve-reactive-streams
branch
from
7695889
to
076be91
Compare
armanbilge
reviewed
Jan 13, 2023
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamSubscription.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Jan 13, 2023
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamSubscription.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Jan 13, 2023
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamUnicastPublisher.scala
Show resolved
Hide resolved
BalmungSan
force-pushed
the
improve-reactive-streams
branch
from
d4f028f
to
d8489a9
Compare
BalmungSan
commented
Jan 14, 2023
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamUnicastPublisher.scala
Show resolved
Hide resolved
BalmungSan
changed the title
armanbilge
reviewed
Jan 15, 2023
reactive-streams/src/test/scala/fs2/interop/reactivestreams/StreamUnicastPublisherSpec.scala
Outdated
Show resolved
Hide resolved
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamUnicastPublisher.scala
Show resolved
Hide resolved
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamSubscription.scala
Outdated
Show resolved
Hide resolved
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamUnicastPublisher.scala
Outdated
Show resolved
Hide resolved
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamSubscription.scala
Outdated
Show resolved
Hide resolved
reactive-streams/src/test/scala/fs2/interop/reactivestreams/StreamUnicastPublisherSpec.scala
Show resolved
Hide resolved
reactive-streams/src/test/scala/fs2/interop/reactivestreams/CancellationSpec.scala
Show resolved
Hide resolved
armanbilge
reviewed
Jan 15, 2023
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamSubscription.scala
Outdated
Show resolved
Hide resolved
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamSubscription.scala
Outdated
Show resolved
Hide resolved
BalmungSan
force-pushed
the
improve-reactive-streams
branch
from
3cffce4
to
4f59581
Compare
armanbilge
reviewed
Jan 15, 2023
reactive-streams/src/main/scala/fs2/interop/reactivestreams/StreamSubscription.scala
Outdated
Show resolved
Hide resolved
BalmungSan
force-pushed
the
improve-reactive-streams
branch
from
4f59581
to
ec155c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the current implementation of
interop.reactivestreams.StreamUnicastPublisherto allow it to be subscribed by multiplePublishersand gracefully cancel activeSubscriptionswhen theResourceis closed.Roadmap.
FlowPR.Related to #3102