Chunk - Add optimised traverse_ for StackSafeMonad. #3191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If our Applicative F is actually an instance of
StackSafeMonad
, we can avoid the default implementation of traverse_, which is based on afoldRight
method of Foldable and has to allocate a set ofEval
objects. Instead, we can just loop on the monad itself.Note Given that in practice Streams are mostly used with IO-like datatypes which are stack-safe, this should have some impact.