Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix comment about followLinks #3273

Merged
merged 1 commit into from
Aug 13, 2023
Merged

fix comment about followLinks #3273

merged 1 commit into from
Aug 13, 2023

Conversation

nikiforo
Copy link
Contributor

@nikiforo nikiforo commented Aug 13, 2023 •
edited
Loading

The fixed comment contradicts with the comment above it.
Also, all other comments about methods with explicit followLinks attribute in Files.scala are used without negation.
Moreover, in sources followLinks means stat, which follows link.

armanbilge
armanbilge approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good catch!

@armanbilge armanbilge merged commit 3c93811 into typelevel:main Aug 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikiforo @armanbilge