Fix Ordering of UDP pending timeouts #3434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
Ordering.by[Timeout, Long](_.expiry)
inAsynchronousSocketGroup
is built the way sopendingTimeouts: PriorityQueue[Timeout]
returns not the closest timeout that can be expired, but the furthest one during.headOption
calls inselectorThread
. Which, when read/write is called frequently, causes theselectorThread
at each iteration to check for a timeout that was just added and does not need to be removed from the queue, causing a memory leak due to the infinite growth ofpendingTimeouts
.I have checked locally that when using
reverse
,pendingTimeouts.headOption
returns a timeout with the closestexpiry
time.Unfortunately, I couldn't figure out a test for it