Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the context.path to the mapping error messages. #281

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

mvalle
Copy link
Contributor

@mvalle mvalle commented Sep 27, 2022

Add the context.path to the mapping error messages, so that it's easier to identify the field that's causing the error.

The error message is in no small part inspired by #250

Copy link
Member

@tpolecat tpolecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@tpolecat tpolecat merged commit a5b287e into typelevel:main Sep 27, 2022
@milessabin
Copy link
Member

I'm fine with this for now, but this is leaking internal errors back to clients and will be changing when #199 is addressed. Provisionally what's going to happen is that all errors which aren't client-directed will go to a distinct internal error channel in Result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants