Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable ignored modules on dependency submission #442

Closed
rossabaker opened this issue Dec 30, 2022 · 5 comments · Fixed by #530
Closed

Configurable ignored modules on dependency submission #442

rossabaker opened this issue Dec 30, 2022 · 5 comments · Fixed by #530

Comments

@rossabaker
Copy link
Member

rossabaker commented Dec 30, 2022

Any Scala 3 build using dependency submission will get 14 useless Dependabot alerts due to stale scaladoc dependencies. I propose a key to ignore a set of modules, to render as the modules-ignore parameter in the GitHub Action.

I already baked this into the plugin at $WORK and can port it here if there's interest, once I confirm that it works.

@armanbilge
Copy link
Member

I noticed we've been getting a lot of build-related Dependabot alerts in Cats Effect as well.

So this seems like a good idea, and maybe we can put in some sensible defaults. For example instead of modules-ignore I wonder if we can config-ignore the test, scala-tool, and scala-doc-tool configs. Also, maybe no-publish projects can automatically register themselves with modules-ignore.

@rossabaker
Copy link
Member Author

Our internal plugin sets a default config-ignore (we don't do test, but I like it) to such good effect that consumers don't typically need to configure anything else. But I like your no-publish idea, too.

@rossabaker
Copy link
Member Author

Maybe also doc? mdoc has a stale pdf-box that's a few dependencies deep. I think it would have about the same pros and cons as ignoring test.

@armanbilge
Copy link
Member

armanbilge commented Apr 29, 2023

Does mdoc fall under doc? I thought it might fall under no-publish but I have no idea 🤔

@rossabaker
Copy link
Member Author

Oh, I don't think doc is right. The configuration is called docs, and it doesn't have a classpath. mdoc and its insecure great-great-great grandchild shows up in doc / Compile. The no-publish rule would do what we want here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants