Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalacOptions don't work properly when combined with sbt-projectmatrix #464

Open
etspaceman opened this issue Feb 5, 2023 · 2 comments
Open

Comments

@etspaceman
Copy link
Collaborator

Per a discussion with @armanbilge - we noticed that the crossScalaVersions will only display 1 scalaVersion when combined with the sbt-projectMatrix plugin. This means that this conditional is met, which is incorrect for projects that also contain Scala 2 cross builds:

https://github.com/typelevel/sbt-typelevel/blob/series/0.4/settings/src/main/scala/org/typelevel/sbt/TypelevelSettingsPlugin.scala#L153

@satorg
Copy link
Contributor

satorg commented Feb 5, 2023

Could you elaborate a bit more please on how to reproduce this?

@armanbilge
Copy link
Member

@satorg here's a reproducer:
https://github.com/armanbilge/scala-native-config-brew/blob/656793d295782ca893e6afd500c347161d1e61b1/build.sbt

If you open that project in sbt and do show core3/scalacOptions, you will see it is setting compiler flags that don't make sense for code that is cross-compiling with Scala 2 (e.g. the underscore mode for kind-projector).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants