use githubWorkflowBuildSbtStepPreamble in publish step #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
May 4, 2023
| @@ -712,6 +712,7 @@ ${indent(jobs.map(compileJob(_, sbt)).mkString("\n\n"), 1)} | |||
| githubWorkflowPublishPreamble.value.toList ::: | |||
| githubWorkflowPublish.value.toList ::: | |||
| githubWorkflowPublishPostamble.value.toList, | |||
| sbtStepPreamble = githubWorkflowBuildSbtStepPreamble.value.toList, | |||
There was a problem hiding this comment.
It doesn't make sense to share this setting between the "build" and "publish" jobs. For example, build jobs use this to narrow an axis of the matrix e.g. ++2.13.10 project rootJS, but publishing doesn't want to do this at all. For publishing this should probably just be empty, this seems like a good change for sbt-tl 0.5.
| sbtStepPreamble: List[String] = List(s"++ $${{ matrix.scala }}"), | ||
| sbtStepPreamble: List[String] = List.empty, |
There was a problem hiding this comment.
👍 but probably better for 0.5.
|
Makes sense. I'm going to close this for now; we can retarget and resurrect it if/when it's ready. |
|
Thanks, ticketed here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this may have been an oversight.
We don't have to change the default value of
sbtStepPreamble, but with this change, the default value is never actually used anymore.