Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circe is broken in community build #485

Closed
ashawley opened this issue Jul 10, 2019 · 3 comments
Closed

Circe is broken in community build #485

ashawley opened this issue Jul 10, 2019 · 3 comments

Comments

@ashawley
Copy link
Contributor

There isn't a lot in master, since 1.14.0 was released, but the community build uncovered a test suite error in circe that could be ScalaCheck related:

[info] JsonCodecMacrosSuite:
[info] io.circe.generic.JsonCodecMacrosSuite *** ABORTED ***
[info]   java.lang.StackOverflowError:
[info]   at io.circe.generic.jsoncodecmacrossuiteaux.SelfRecursiveWithOption$.$anonfun$arbitrarySelfRecursiveWithOption$1(JsonCodecMacrosSuite.scala:154)
[info]   at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary$lzycompute(Arbitrary.scala:75)
[info]   at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary(Arbitrary.scala:75)
[info]   at org.scalacheck.ArbitraryLowPriority.$anonfun$arbOption$1(Arbitrary.scala:339)
[info]   at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary$lzycompute(Arbitrary.scala:75)
[info]   at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary(Arbitrary.scala:75)
[info]   at org.scalacheck.ArbitraryLowPriority.arbitrary(Arbitrary.scala:79)
[info]   at org.scalacheck.ArbitraryLowPriority.arbitrary$(Arbitrary.scala:79)
[info]   at org.scalacheck.Arbitrary$.arbitrary(Arbitrary.scala:62)
[info]   at io.circe.generic.jsoncodecmacrossuiteaux.SelfRecursiveWithOption$.atDepth(JsonCodecMacrosSuite.scala:147)
[info]   ...
[info] SemiautoDerivedSuite:
[info] io.circe.generic.JsonCodecMacrosSuite *** ABORTED ***
[info]   java.lang.StackOverflowError:
[info]   at io.circe.generic.jsoncodecmacrossuiteaux.SelfRecursiveWithOption$.$anonfun$arbitrarySelfRecursiveWithOption$1(JsonCodecMacrosSuite.scala:154)
[info]   at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary$lzycompute(Arbitrary.scala:75)
[info]   at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary(Arbitrary.scala:75)
[info]   at org.scalacheck.ArbitraryLowPriority.$anonfun$arbOption$1(Arbitrary.scala:339)
[info]   at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary$lzycompute(Arbitrary.scala:75)
[info]   at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary(Arbitrary.scala:75)
[info]   at org.scalacheck.ArbitraryLowPriority.arbitrary(Arbitrary.scala:79)
[info]   at org.scalacheck.ArbitraryLowPriority.arbitrary$(Arbitrary.scala:79)
[info]   at org.scalacheck.Arbitrary$.arbitrary(Arbitrary.scala:62)
[info]   at io.circe.generic.jsoncodecmacrossuiteaux.SelfRecursiveWithOption$.atDepth(JsonCodecMacrosSuite.scala:147)
[info]   ...
[info] Codec[Seq[WithSeqOfTagged]]
[info] - should obey codec.consistency with accumulating
[info] - should obey codec.decoder serializability
[info] - should obey codec.encoder serializability
[info] - should obey codec.roundTrip
[error] java.lang.StackOverflowError
[error] 	at io.circe.generic.jsoncodecmacrossuiteaux.SelfRecursiveWithOption$.$anonfun$arbitrarySelfRecursiveWithOption$1(JsonCodecMacrosSuite.scala:154)
[error] 	at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary$lzycompute(Arbitrary.scala:75)
[error] 	at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary(Arbitrary.scala:75)
[error] 	at org.scalacheck.ArbitraryLowPriority.$anonfun$arbOption$1(Arbitrary.scala:339)
[error] 	at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary$lzycompute(Arbitrary.scala:75)
[error] 	at org.scalacheck.ArbitraryLowPriority$$anon$1.arbitrary(Arbitrary.scala:75)
[error] 	at org.scalacheck.ArbitraryLowPriority.arbitrary(Arbitrary.scala:79)
[error] 	at org.scalacheck.ArbitraryLowPriority.arbitrary$(Arbitrary.scala:79)
[error] 	at org.scalacheck.Arbitrary$.arbitrary(Arbitrary.scala:62)
...
@ashawley
Copy link
Contributor Author

ashawley commented Jul 10, 2019

Seems it could be #401.

@ashawley
Copy link
Contributor Author

Should probably add a test to the test suite to verify Arbitrary.arbOption can handle recursive generators. This wasn't a scenario that had been considered, but maybe there's a way to accommodate it by changing the frequence of Some v. None.

@ashawley
Copy link
Contributor Author

Should be fixed in circe/circe#1204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant