Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish 1.14.3 #591

Closed
ashawley opened this issue Dec 12, 2019 · 19 comments
Closed

Publish 1.14.3 #591

ashawley opened this issue Dec 12, 2019 · 19 comments
Milestone

Comments

@ashawley
Copy link
Contributor

ashawley commented Dec 12, 2019

I was going to try and prepare a release of Scala.js 1.0.0-RC1 in #587 but it might be better to just release 1.14.3 with the Scala.js artifacts and with the bug-fix in #569.

Plus, a 1.0.0-RC2 version of Scala.js was released, yesterday.

@ashawley
Copy link
Contributor Author

Drafted the release notes in #593.

@ashawley
Copy link
Contributor Author

Going to cherry-pick the Scala.js 0.6.31 update while we're at it, see #594.

@SethTisue
Copy link
Member

perhaps the release note should mention that #581 got fixed as well (as a consequence of the #568 fix)

@ashawley
Copy link
Contributor Author

That's a good question. I read #581 as the same issue in #568. We can just close as a duplicate.

However, the issue with collection generators having a higher probability of failing because of the poor performing posNum or any unreliable generator will live on in #568. Erik suggested it could be improved somehow.

@ashawley
Copy link
Contributor Author

Dear @djspiewak,

I've tagged commit 6464e98 as 1.14.3, on the 1.14.x branch, and pushed up the tag. Would you be able to deploy the branch? Just start reading the directions at the top of the shell script, release.sh. You can start at step 4. This is a relatively new script that is a WIP, so apologies in advance if it gives you trouble.

Thank you!

@ashawley ashawley added this to the 1.14.3 milestone Dec 13, 2019
@djspiewak
Copy link
Member

Script appears to be working! Release is uploading.

@djspiewak
Copy link
Member

djspiewak commented Dec 13, 2019

@ashawley Looks like the script is missing a sonatypeReleaseAll command. I'll run that manually.

Another problem I ran into is the fact that I don't actually have an sbt command, but rather an alias. The script doesn't deal with this correctly.

@djspiewak
Copy link
Member

Oh holy crap it's not using sbt-sonatype. Wow. Okay I closed the staging repository by hand. We should probably fix that. :-)

@djspiewak
Copy link
Member

Kk if I did things correctly, 1.14.3 should be propagating to Maven Central.

@ashawley
Copy link
Contributor Author

Thanks, Daniel. Will keep an eye out for them.

@ashawley
Copy link
Contributor Author

Are you seeing them, yet? I'm not seeing anything. Looking here for instance:

https://repo1.maven.org/maven2/org/scalacheck/scalacheck_2.13/1.14.3/

@djspiewak
Copy link
Member

Just goes to show how long it's been since I released anything on Sonatype by hand… I forgot to release the repository; I just closed it. It should be syncing now. I think.

@djspiewak
Copy link
Member

Also, appropriately enough, @xerial reacted to my post above. Much love!

@xerial
Copy link
Contributor

xerial commented Dec 13, 2019

Yeah. I'm waiting for the release :)

I guess it's a timing to automate the release on CI with sbt-sonatype. Here is some example https://github.com/wvlet/airframe/blob/master/.github/workflows/release.yml

or using sbt-ci-release will be handy https://github.com/olafurpg/sbt-ci-release

@ashawley
Copy link
Contributor Author

Ok, looks like they got released. Thanks again for the help.

@djspiewak
Copy link
Member

I guess it's a timing to automate the release on CI with sbt-sonatype. Here is some example https://github.com/wvlet/airframe/blob/master/.github/workflows/release.yml

Yeah it wouldn't be too difficult to do this, honestly, though I personally prefer with OSS projects to keep the actual release process local to a developer machine (since it's not clear who's GPG key and Sonatype credentials get ceded to Travis' control, but it's not an entirely comfortable feeling either way). At the very least, using sbt-sonatype rather than manually publishing to Sonatype would be a good and easy step forward.

@ashawley
Copy link
Contributor Author

Yeah, sorry about all the difficulty. I guess I'll look in to doing it myself in the future. I've just been putting it off.

@djspiewak
Copy link
Member

It actually wasn't all that bad. Just ran into some issues that should be reasonably easy to fix.

@xerial
Copy link
Contributor

xerial commented Dec 13, 2019

@djspiewak It makes sense. Having a script to publish from a local machine will be a good starting point.

  1. Build artifacts for all cross-build combinations (e.g., Scala.js 0.6.x, 1.0.x) into a local staging folder
  2. Run sonatypeBundleRelease once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants