fix: resolves issue proto-less object validation #6884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you create tests that verify this fixes the erroneous behavior? |
|
@imnotjames Added tests :) |
imnotjames
approved these changes
Oct 12, 2020
|
Thanks for the contribution and fixing this long outstanding issue :) |
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
Due to `instanceof` comparison, object without prototype is mistaken for a privative value, throwing `TypeError: Cannot convert object to primitive value.` when trying to `.toString` said object (inside template string). This mostly effects usage with `graphql` as `graphql-js`, [by design](graphql/graphql-js#504), creates objects by using Object.create(null). This fix allows saving these objects. The fix uses `typeof` instead of `toString` comparison since I see no reason why `new Number/Boolean/Date` should be a supported use case. Closes: typeorm#2065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to
instanceofcomparison, object without prototype is mistaken for a privative value, throwingTypeError: Cannot convert object to primitive value.when trying to.toStringsaid object (inside template string).This mostly effects usage with
graphqlasgraphql-js, by design, creates objects by using Object.create(null).This fix allows saving these objects.
The fix uses
typeofinstead oftoStringcomparison since I see no reason whynew Number/Boolean/Dateshould be a supported use case.Closes: #2065