Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply conn drop fix (Fix #7640) #7641

Merged
merged 6 commits into from
May 15, 2021

Conversation

joao-felipe-santoro
Copy link
Contributor

@joao-felipe-santoro joao-felipe-santoro commented May 10, 2021

Description of change

I'm merely replicating a fix that was made way back in 2018 in issue #1689 for MySQL, thou this time also applying it to Slave connections and not only the master one.

Fixes #7640

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@joao-felipe-santoro joao-felipe-santoro changed the title Apply conn drop fix Apply conn drop fix (Fix #7640) May 10, 2021
@AlexMesser
Copy link
Collaborator

@joao-felipe-santoro can you please apply the same fix in the same place in the AuroraDataApiDriver

@AlexMesser AlexMesser merged commit 882a740 into typeorm:master May 15, 2021
@AlexMesser
Copy link
Collaborator

thank you for contribution!

@joao-felipe-santoro joao-felipe-santoro deleted the apply-conn-drop-fix branch May 15, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL/Aurora Slave connection Error not handled.
2 participants