Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for specifying ioredis cache with a URL (to conf… #7689

Merged
merged 1 commit into from
May 29, 2021
Merged

fix: add support for specifying ioredis cache with a URL (to conf… #7689

merged 1 commit into from
May 29, 2021

Conversation

JoeCap08055
Copy link
Contributor

@JoeCap08055 JoeCap08055 commented May 27, 2021

…orm to ioredis docs)

According to the ioredis documentation, a URL may be passed in the 'port' parameter.
This does not currently work when using an ioredis cache. Modify ioredis connection logic
to conform to ioredis standards.

Closes: #7631

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

… to ioredis docs)

    According to the ioredis documentation, a URL may be passed in the 'port' parameter.
    This does not currently work when using an ioredis cache. Modify ioredis connection logic
    to conform to ioredis standards.

    Closes: #7631
@AlexMesser AlexMesser merged commit e017f9b into typeorm:master May 29, 2021
@AlexMesser
Copy link
Collaborator

thank you for contribution!

@JoeCap08055 JoeCap08055 deleted the fix/cache_option_support_ioredis_url branch June 3, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use URL in ioredis cache options
2 participants