fix: mongo replica set #7908
Merged
fix: mongo replica set #7908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So all testcase use a uniform expectation library
imnotjames
reviewed
Jul 15, 2021
imnotjames
reviewed
Jul 15, 2021
imnotjames
approved these changes
Jul 17, 2021
21 tasks
imnotjames
pushed a commit
to imnotjames/typeorm
that referenced
this pull request
Jul 21, 2021
* test: migrates should syntax to expect So all testcase use a uniform expectation library * fix: adds replicaSet and tls option to mongo connection url fixes 7130 * test: add a unit test for the connection string building
imnotjames
pushed a commit
to imnotjames/typeorm
that referenced
this pull request
Jul 21, 2021
* test: migrates should syntax to expect So all testcase use a uniform expectation library * fix: adds replicaSet and tls option to mongo connection url fixes 7130 * test: add a unit test for the connection string building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From typeorm > 0.2.28 parsing the connection string broke our database setup. In our setup we use a replicaSetup - however the required parameters tls and replicaSet were never added to the connection string.
This PR will add the two parameters, in addition to a new test that parses the connection string (as I was looking for how the parsing works).
There is no new test for the actual adding of the two query parameters. If you can point me towards an example test case, I can also provide one for this case.
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000