allow lock modes for cockroachdb

[wodka]

fixes #8249

Description of change

allow the same lock modes as postgres - https://www.cockroachlabs.com/docs/stable/select-for-update.html

currently an exception is thrown when a lock is used in a transaction

Adds Support for:

• pessimistic_write
• pessimistic_write_or_fail
• for_no_key_update

Pull-Request Checklist

• Code is up-to-date with the master branch
• npm run lint passes with this change
• npm run test passes with this change
• This pull request links relevant issues as Fixes #0000
• There are new or updated unit tests validating the change
• Documentation has been updated to reflect this change
• The new commits follow conventions explained in CONTRIBUTING.md

[wodka]

:/ at this point I have no clue why the test are failing - there should be based on the code not be a change in postgre itself and cockroach compains about a part that should also not be affected.

[imnotjames]

I've kicked off the tests again. I think the non-cockroach failures were just flakey tests that we should eventually remove.

The cockroach failures seemed to point at some sort of an issue.

[wodka]

@imnotjames the previous test fails with a non recoverable error in the connection - and then cannot recover before the next test

[pleerock]

can you check if version running in CI match the version where this feature support was added?

[wodka]

@pleerock I'm using CockroachDB (ver. 21.1.10) locally - and in circleCI cockroachdb/cockroach:latest-v21.1 is beeing run (21.1.10)

only difference is that locally I am using node 16 and ci runs with node 12

[pleerock]

I've restarted CockroachDB tests again, and if they fail... You need to figure out why, because I don't have ideas. Maybe you can try to remove your code and do pushes one by one until it fail?

[wodka]

I'll try that - hopefully it will yield some result^^

[pleerock]

Still failing.

[wodka]

pushed a new change - seems like that at one place when using the exception the transaction is not closed.

it("should throw error when specifying a table that is not part of the query", () => Promise.all(connections.map(async connection => {
        if (!(connection.driver instanceof PostgresDriver || connection.driver instanceof CockroachDriver))
            return;

        return connection.manager.transaction(entityManager => {
            return Promise.all([
                entityManager.createQueryBuilder(Post, "post")
                    .innerJoin("post.author", "user")
                    .setLock("pessimistic_write", undefined, ["img"])
                    .getOne()
                    // having the should.be here will prevent the transaction from closing.
                    //.should.be.rejectedWith('relation "img" in FOR UPDATE clause not found in FROM clause'),
            ]);
         // moving the should.be here will allow the transaction to be closed correctly.
        }).should.be.rejectedWith('relation "img" in FOR UPDATE clause not found in FROM clause');
    })));

:/ not sure why this behaviour happens in the first place as other exceptions do not break like this. I'm curious if this will now run through in circle ci

[wodka]

Woho :)

[pleerock]

Thank you!