fix: add referencedSchema to PostgresQueryRunner #8566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Right now, when using PostgreSQL, relations that point to tables in a different schema will have their foreign constraints generated every migration, even if they already exist.
This is because when checking for the constraint's target,
referencedSchema
is used to prefix the column name(s). However, in PostgresQueryRunner,referencedSchema
is never set, so the query runner thinks the existing constraint is pointing topublic
schema, even if it isn'tThis PR adds
referencedSchema
to the PostgresQueryRunner loading of foreign keys.Fixes #8565
Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000
I didn't know what tests to add as there were no existing tests regarding
referencedSchema
Also I don't believe this exists in the documentation