Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing connect call on RedisQueryResultCache connect #8894

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

mesinger
Copy link
Contributor

Description of change

Fixes #8725 (comment)

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@mesinger
Copy link
Contributor Author

Whether test nor test-fast work on my machine, I suppose you're aware of that...

@pleerock
Copy link
Member

Whether test nor test-fast work on my machine, I suppose you're aware of that...

nope. Why?

@mesinger
Copy link
Contributor Author

@pleerock

Steps to reproduce

git clone https://github.com/typeorm/typeorm.git
cd typeorm
npm install
npm run test

npm version 8.3.1

fails with

> typeorm@0.3.5 test
> rimraf ./build && tsc && mocha --file ./build/compiled/test/utils/test-setup.js --bail --recursive --timeout 60000 ./build/compiled/test



  benchmark > bulk-save > case1
    1) "before all" hook for "testing bulk save of 10.000 objects"
    2) "after all" hook for "testing bulk save of 10.000 objects"


  0 passing (21ms)
  2 failing

  1) benchmark > bulk-save > case1
       "before all" hook for "testing bulk save of 10.000 objects":
     Error: Cannot find ormconfig.json file in the root of the project. To run tests please create ormconfig.json file in the root of the project (near ormconfig.json.dist, you need to copy ormconfig.json.dist into ormconfig.json and change all database settings to match your local environment settings).
      at getOrmFilepath (test/utils/test-utils.ts:204:15)
      at getTypeOrmConfig (test/utils/test-utils.ts:213:20)
      at setupTestingConnections (test/utils/test-utils.ts:223:45)
      at createTestingConnections (test/utils/test-utils.ts:382:31)
      at Context.<anonymous> (test/benchmark/bulk-save-case1/bulk-save-case1.ts:14:58)
      at processImmediate (node:internal/timers:466:21)

  2) benchmark > bulk-save > case1
       "after all" hook for "testing bulk save of 10.000 objects":
     TypeError: Cannot read properties of undefined (reading 'map')
      at closeTestingConnections (test/utils/test-utils.ts:483:21)
      at Context.<anonymous> (test/benchmark/bulk-save-case1/bulk-save-case1.ts:20:40)
      at processImmediate (node:internal/timers:466:21)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants