Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect incorrect line endings in code #115

Closed
krzema12 opened this issue Mar 5, 2022 · 3 comments
Closed

Detect incorrect line endings in code #115

krzema12 opened this issue Mar 5, 2022 · 3 comments
Labels
operational Operational Excellence - maintenance tasks.

Comments

@krzema12
Copy link
Member

krzema12 commented Mar 5, 2022

No description provided.

@krzema12
Copy link
Member Author

krzema12 commented Mar 5, 2022 •
edited
Loading

pinterest/ktlint#225 (comment) - seems to be irrelevant for checking, just relevant for formatting.

@krzema12 krzema12 mentioned this issue Mar 6, 2022
Closed
@krzema12 krzema12 added the operational Operational Excellence - maintenance tasks. label Mar 8, 2022
@krzema12
Copy link
Member Author

https://kotlinlang.slack.com/archives/CKS3XG0LS/p1646902592787839

@krzema12
Copy link
Member Author

Happened only once that the line ending changed, and it was detected in code review. Its also challenging to catch it automatically. Let's resolve it for now and get back to it once it becomes a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
operational Operational Excellence - maintenance tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krzema12