feat(typescript-estree): tighten prop name and destructure types #1346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on #1318, I noticed that the types for both property names and destructuring were wrong.
property names assumed that only
Identifier | Literal
were valid, when in fact any expression is valid, if and only if the name is computed:{ [1 + 2]: 1 }
.Part of me thinks we should probably split the types to make this nicer (I've raised #1345)
The destructuring types were also inconsistent, so I corrected them.