Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backports.zoneinfo to allowed dependencies #145

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Add backports.zoneinfo to allowed dependencies #145

merged 4 commits into from
Oct 2, 2024

Conversation

srittau
Copy link
Contributor

@srittau srittau commented Oct 2, 2024

Also improve error message when dependency is missing

backports.zoneinfo is maintained by CPython core developer @pganssle, so it's uncritical. Required for python/typeshed#12706.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Contributor

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like my suggestion broke a few tests that now need to be tweaked, but LGTM other than that

@srittau srittau merged commit a8a471b into main Oct 2, 2024
6 checks passed
@srittau srittau deleted the zoneinfo branch October 2, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants