All primitive types are @Interned
#6865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes typetools#6371. The interning checker does not apply `@Interned` to every occurrence of every primitive type. This allows some language constructs to fabricate non-interned primitive values, leading to false positives. For instance, in the new `loopVariables` test, the loop variable `i` was assigned the type `@UnknownInterned long`. Thus `i` could not be used as an argument to `addExact` which requires interned arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6371.
The interning checker does not apply
@Internedto every occurrence of every primitive type. This allows some language constructs to fabricate non-interned primitive values, leading to false positives.For instance, in the new
loopVariablestest, the loop variableiwas assigned the type@UnknownInterned long. Thusicould not be used as an argument toaddExactwhich requires interned arguments.