Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvm shouldn't be skipped even if a global Node installation (e.g. via Homebrew) is present #106

Closed
mgol opened this issue Mar 6, 2017 · 4 comments
Labels

Comments

@mgol
Copy link

mgol commented Mar 6, 2017

I have a few Node.js versions installed via nvm but I also have one from Homebrew. nvm supports such scenario; it lists the globally installed Node as "system", allows to switch to it etc.

In one of my projects I require a Node version matching >=6.5.0 <7.0.0; other versions are rejected. However, the global package is now at 7.1.1. I have a proper .nvmrc (with contents: 6) in my project but now it seems not invoked. The hooks get invoked with the global Node.js and the whole script fails.

I've seen the following entry in the 0.13.0 changelog entry:

Fixes issue with OS X + brew where nvm was loaded even when npm was already present

It seems this change is doing exactly opposite to what I'd expect. :/

It works fine in 0.12.0.

@typicode typicode added the bug label Mar 7, 2017
@typicode
Copy link
Owner

typicode commented Mar 8, 2017

Thank you for the report @mgol, it's an unexpected side effect.
I'll have a look this week-end.

@typicode
Copy link
Owner

Could you try with npm install --save-dev husky@0.13.3-0?

@mgol
Copy link
Author

mgol commented Mar 21, 2017

Sorry for the delay. I confirm 0.13.3-0 fixes my issue.

@typicode
Copy link
Owner

It's published v0.13.3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants