Missing escape of single quote. PHP Parse error produced.

[dfelton]

When the "Note" attribute of an entity's field/attribute contains single quote(s), they are not being escaped when put into the corresponding instance of the Varien_Data_Form_Element_Abstract element for the field/attribute. This results in an improperly ended string, producing a PHP Parse error.

app/code/{{codepool}}/{{Namespace}}/{{Module}}/Block/Adminhtml/{{Entity}}/Edit/Form.php
Example Generated Source:

$fieldset->addField(
    'foo_bar',
    'text',
    array(
        'label' => Mage::helper('foo_bar')->__('Foo Bar'),
        'name'  => 'foo_bar',
        'note'  => $this->__('Foo's Bar'),
        'required'  => true,
        'class' => 'required-entry',
    )
);

[tzyganu]

Thanks for spotting this. I will fix it as soon as I have the time. Of course your PR is always welcomed 😄

[dfelton]

@tzyganu your welcome. Yes if I have time first I'll dig into it as well. Oh how I wish there was 48 hours in a day, and the human body was built to handle such hours.

[fffab]

Hi, @tzyganu @dfelton i did just spotted the same on 'label'. For example
'label' => Mage::helper('foo_bar')->__('Foo's Bar'),

[tzyganu]

@dfelton @fffab These issues should be fixed in version 1.9.6.0