Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two status fields are being generated #73

Closed
fbrnc opened this issue Dec 16, 2014 · 3 comments
Closed

Two status fields are being generated #73

fbrnc opened this issue Dec 16, 2014 · 3 comments
Labels

Comments

@fbrnc
Copy link
Contributor

fbrnc commented Dec 16, 2014

It looks like there's always TWO status fields being generated (btw, in some case I wouldn't want even one of these...)

...
    ->addColumn('status', Varien_Db_Ddl_Table::TYPE_SMALLINT, null, array(
        ), 'Enabled')

     ->addColumn('status', Varien_Db_Ddl_Table::TYPE_INTEGER, null, array(
        ), 'Log Status')
    ->addColumn('updated_at', Varien_Db_Ddl_Table::TYPE_TIMESTAMP, null, array(
            ), 'Log Modification Time')
    ->addColumn('created_at', Varien_Db_Ddl_Table::TYPE_TIMESTAMP, null, array(
        ), 'Log Creation Time') 
    ->setComment('Log Table');
$this->getConnection()->createTable($table);
$this->endSetup();
@pljspahn
Copy link

I noticed this today as well. Would be nice to make this an option.

@tzyganu
Copy link
Owner

tzyganu commented Dec 16, 2014

@fbrnc Thanks for spotting this. It will be fixed in the next version. Good thing that the addColumn method knows how to handle these duplicates.
As for making the 'status' field configurable, I agree with you, it would be nice to have, but unfortunately it involves a lot of work. Specially for the generation of the frontend files and tree behaving entities. You can see here a longer explanation

@tzyganu tzyganu added the bug label Dec 16, 2014
@tzyganu
Copy link
Owner

tzyganu commented Dec 19, 2014

@fbrnc @pljspahn There should be only one status field in the install scripts starting with version 1.9.5.0

@tzyganu tzyganu closed this as completed Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants