-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x.com: ads #23732
Comments
ublock filters need to be updated to x.com they recently redirected from twitter.com to x.com domain |
It's already updated: f93e44f |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@gorhill Not related to this issue, but Can you publish a new version of uBOL ASAP for the domain change? I think having no way to quickly fix mega-sites like Twitter, youtube is not good mentally. A lot of user will move to uBOL the next month, and people will cry when they see ads or breakage on them. We can only hope you can respond quickly in such cases. |
The fixes to Twitter mostly relate to cosmetic filters, these cannot be updated dynamically (neither scriptlets). MV3 dynamic filters is only for network filters, not very useful when a big share of filter changes are cosmetic- or scriptlet-based filters. |
As I said, I saw a sponsored tweet, I tried to block the user (in reticenses menu), and after this, the nag screen (as shown in screenshot) appears. I will do more tests, if I won't respond, the issue was solved. |
As DNR is only about network filters, why can cosmetic filters not be updated dynamically? @Alex-302 said custom filters in AGMV3 can update cosmetic filters dynamically, though is not implmented yet. |
Because they are injected declaratively through Sure, they can be injected dynamically but this would require the following sequence to take place:
The big issue is the wake up of the extension's service worker, which adds delay, which will produce a delay before the cosmetic filters are applied. I chose to go the reliable route for cosmetic and scriplet filtering by relying completely on the declarative approach. I demonstrate here the delay and CPU-/memory-spike issue: https://github.com/uBlockOrigin/uBOL-home/wiki/Frequently-asked-questions-(FAQ)#is-ubo-lite-a-bad-faith-attempt-at-converting-ubo-to-mv3 -- I can add the same sort of demonstration for cosmetic filters. Also, the non-declarative approach requires to put in all the code responsible for compiling/storing filters, a sizeable amount of code. I chose the reliable and lean approach, hence the limitations. Whoever wants more than what uBO Lite offers will have to find another solution, uBO Lite is not for them. |
Prerequisites
URL address of the web page
https://x.com/i/verified-get-verified
Category
ads
Description
An annoying nag screen appears whenever I block a sponsored tweet.
Other extensions used
Nothing.
Screenshot(s)
Screenshot(s)
Configuration
The text was updated successfully, but these errors were encountered: