Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onwebchange.com #7647

Closed
ghost opened this issue Jul 7, 2020 · 9 comments
Closed

onwebchange.com #7647

ghost opened this issue Jul 7, 2020 · 9 comments
Labels

Comments

@ghost
Copy link

ghost commented Jul 7, 2020

URL(s) where the issue occurs

https://onwebchange.com/

Describe the issue

Bottom cookie notice annoyance. Adguard won't hide it because they believe it has low traffic.

Screenshot(s)

cookies

Versions

  • Browser/version: Firefox stable
  • uBlock Origin version: 1.27.10

Settings

Adguard Base + Annoyances + Portuguese + Russian + Social Media + Tracking Protection
uBlock Origin lists

@liamengland1
Copy link
Contributor

#4123 (comment) ...

@ghost
Copy link
Author

ghost commented Jul 7, 2020

@llacb47 uBlock filters -- Annoyances now has rules with the strings cookie and gdpr.

@JobcenterTycoon
Copy link
Contributor

No cookie banner for me when i enable EasyList Cookie and Fanboy’s Annoyance

@ghost
Copy link
Author

ghost commented Jul 7, 2020

@JobcenterTycoon I use the Adguard lists instead, as I've pointed out in the report.

@okiehsch
Copy link
Contributor

okiehsch commented Jul 8, 2020

uBlock filters -- Annoyances now has rules with the strings cookie and gdpr.

The readme clearly states that GDPR modals won't be addressed in uAssets.
uBlock-user does add filters for cookie messages to the annoyance list.

@okiehsch
Copy link
Contributor

okiehsch commented Jul 8, 2020

Looking at all gdpr strings in the annoyance list, the only one that blocks a GDPR modal is the one for imaginetricks.com as far as I can see. I will remove that one.
5450941

@uBlock-user
Copy link
Contributor

uBlock filters -- Annoyances now has rules with the strings cookie and gdpr.

Websites use "gdpr" and "cookie" as prefixes for their CSS selectors, that's not something we can control and they're cookie notices, so they get blocked.

@uBlock-user
Copy link
Contributor

uBlock-user commented Jul 8, 2020

As for this case, add onwebchange.com##.cookie_bg to my Filters.

@krystian3w
Copy link
Contributor

@okiehsch IMO removed half selectors only recover anti-select in pop-up.

If filter have puted :style() it's not standard practice to hide if you don't reach for display: none !important; or visibility: hidden !important; height: 0 !important; width: 0 !important; inside brackets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants