Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aost logging breaks video on website #3365

Closed
9 tasks done
ghajini opened this issue Sep 5, 2024 · 2 comments
Closed
9 tasks done

aost logging breaks video on website #3365

ghajini opened this issue Sep 5, 2024 · 2 comments
Labels
wontfix won't be addressed

Comments

@ghajini
Copy link

ghajini commented Sep 5, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

using
deltabit.co##+js(aost, document.createElement) breaks video on website

A specific URL where the issue occurs.

https://deltabit.co/52tiyuhsq52y

Steps to Reproduce

  1. add deltabit.co##+js(aost, document.createElement) to my filters
  2. visit website

Expected behavior

video on website not broken
image

Actual behavior

video on website is blank
image

uBO version

1.59.1b11

Browser name and version

opera stable

Operating System and version

win 10

@ghajini ghajini changed the title aost logging breaks site aost logging breaks video on website Sep 5, 2024
@gorhill
Copy link
Member

gorhill commented Sep 5, 2024

Issue is caused by the site's code using deprecated RegExp.$1. Scriptlet's use of regex overwrite the $1 static property. Possible solution is for the scriptlet to save/restore these deprecated properties.


Save/restore won't work, as per documentation:

The set accessor of each property is undefined, so you cannot change the properties directly.

Not sure it's worth doing something about this, the site's code will break anyways once those deprecated properties are no longer supported.

@ghajini
Copy link
Author

ghajini commented Sep 5, 2024

ok, i will close

@ghajini ghajini closed this as completed Sep 5, 2024
@MasterKia MasterKia added the wontfix won't be addressed label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix won't be addressed
Projects
None yet
Development

No branches or pull requests

3 participants