Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I see no difference when "[x]Hide placeholders of blocked elements" is checked or not. #3485

Closed
9 tasks done
user0022 opened this issue Dec 14, 2024 · 2 comments
Closed
9 tasks done
Labels
invalid not a uBlock issue

Comments

@user0022
Copy link

user0022 commented Dec 14, 2024

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Hello!
I use uBO with Firefox 128.5 ESR and Snap 133, under Lubuntu 22.04 OS.

And in Settings tab I use the [x] Block media elements larger than [5 ] KB feature.
So when an image is blocked, I see a placeholder (a square of small red dots, or a "no image" icon...).
When I also have [x]Hide placeholders of blocked elements checked (on top of the page of the Settings tab), I imagine these placeholders would totally disappear, but on any page, they are still here.
This is not how I would personnally want to use it, as I prefer to have a placeholder to click on to load missing images sometimes, but it looks like a bug to me?

Remark:
I checked "[x] I verified that this is not a filter list issue (...)" because otherwise it seemed that I couldn't post the issue, but in fact didn't do the thing as I didn't really understand it but didn't have the impression that the problem came from here.
But I made all other verifications, in 128 ESR, and in Snap 133 when creating a new profile was needed.

A specific URL where the issue occurs.

Seen everywhere, just a random example:
https://en.wikipedia.org/wiki/Pythagoras

Steps to Reproduce

  1. In Settings tab, check [x] Block media elements larger than [...] KB, and choose a small limit, like 5KB.
  2. In the same tab, have unchecked [ ]Hide placeholders of blocked elements
  3. Go to a random URL, where the page contains images, and see that there are placeholders for blocked images.
  4. Check [x]Hide placeholders of blocked elements
  5. Go to another random page with images, and see that placeholders are still here, so not hidden.

Expected behavior

When [x]Hide placeholders of blocked elements is checked, placeholders should disappear, and their space collapsed.

Actual behavior

Placeholders are still here.

uBO version

1.61.2

Browser name and version

Firefox 128.5 ESR and Snap 133.

Operating System and version

Lubuntu 22.04.

@gwarser
Copy link

gwarser commented Dec 14, 2024

If an item is hidden, you won't be able to click on it to unlock it, as you noticed. This works as expected.


Maybe, something can be added about it in the doc - https://github.com/gorhill/uBlock/wiki/Dashboard:-Settings#hide-placeholders-of-blocked-elements

@gwarser gwarser added the invalid not a uBlock issue label Dec 14, 2024
@gorhill gorhill closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2024
@gorhill
Copy link
Member

gorhill commented Dec 14, 2024

but it looks like a bug to me?

No, it's how it works. This won't change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid not a uBlock issue
Projects
None yet
Development

No branches or pull requests

3 participants