Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support loading multiple databases files #70

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Support loading multiple databases files #70

merged 1 commit into from
Oct 21, 2022

Conversation

misdoro
Copy link
Contributor

@misdoro misdoro commented Jan 21, 2020

Allow passing multiple pattern databases as an array to the new patterns_paths argument

  • Support patterns_path argument but deprecate pattern_path attribute accessor
  • Add new patterns_paths array argument to enable loading multiple patterns files
  • Use keyword arguments instead of options array
  • Always use the faster match version since we already require ruby 2.4 in gemspec

Fixes #11

@misdoro misdoro requested a review from wallin January 21, 2020 18:18
@misdoro misdoro changed the title Multiple databases Support loading multiple databases files Jan 21, 2020
@misdoro misdoro force-pushed the multiple_databases branch 2 times, most recently from dce8e66 to 4935ee0 Compare December 24, 2021 14:06
@misdoro
Copy link
Contributor Author

misdoro commented Dec 24, 2021

Hello @opti, I saw you released a latest version of the gem.
Is there a chance this pull request and #68 could be reviewed/merged?

@misdoro misdoro force-pushed the multiple_databases branch from 4935ee0 to cddd73f Compare October 21, 2022 10:09
@misdoro
Allow passing multiple pattern databases as an array to the new `patt…
a612ca4 
…erns_paths` argument

- Support `patterns_path` argument but deprecate `patterns_path` attribute accessor
- Add new `patterns_paths` array argument and accessor to enable loading multiple patterns files

Fixes ua-parser#11
@misdoro misdoro force-pushed the multiple_databases branch from cddd73f to a612ca4 Compare October 21, 2022 16:21
@opti opti merged commit 4a29630 into ua-parser:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opti opti opti approved these changes

@wallin wallin Awaiting requested review from wallin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for addtional custom databases
2 participants
@misdoro @opti