Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to simplify the rebase process #175

Open
uazo opened this issue May 4, 2023 · 4 comments
Open

Try to simplify the rebase process #175

uazo opened this issue May 4, 2023 · 4 comments
Labels
wip work in progress

Comments

@uazo
Copy link
Owner

uazo commented May 4, 2023 •
edited
Loading

done uazo/cromite#335 and the policy patch I can begin the work of patch cleanup.

  • Disable safe browsing
  • Remove signin and sync integrations
  • Remove price/shopping/commerce integrations
  • Remove contextual search manager
@uazo uazo added enhancement New feature or request high priority wip work in progress labels May 4, 2023
@uazo
Copy link
Owner Author

uazo commented May 7, 2023 •
edited
Loading

fixed in uazo/cromite@6383e88 EDIT: forgot gn args uazo/cromite@151e6e4

patches replaced with policy

some changes to other patches were necessary, working with uazo/cromite@762b01a

no functionality was lost, I will revise the settings panel

#131 uazo/cromite#335

@uazo
Copy link
Owner Author

uazo commented May 7, 2023 •
edited
Loading

next step

  • Disable-safety-check.patch
  • Remove-voice-recognition-integration.patch
  • Remove-binary-blob-integrations.patch (check ReplaceGmsPackageIfNeeded in build/android/gyp/javac_output_processor.py)
  • Allow building without enable_reporting

@uazo uazo mentioned this issue May 8, 2023
Closed
@uazo uazo mentioned this issue May 20, 2023
Closed
@uazo
Copy link
Owner Author

uazo commented May 20, 2023

uazo/cromite@6d194a1 deativate kDocumentReporting and kReporting

@uazo uazo changed the title Try to remove large patches Try to simplify the rebase process May 20, 2023
@uazo uazo removed enhancement New feature or request high priority labels May 20, 2023
This was referenced May 20, 2023
Open
Closed
@uazo uazo mentioned this issue Jun 2, 2023
Closed
@uazo uazo mentioned this issue Jun 21, 2023
Merged
9 tasks
@uazo
Copy link
Owner Author

uazo commented Jul 16, 2023

satisfied, it took me much less with the 115.

Remove voice recognition integration should be in the priority also because it is not complete uazo/cromite#83
Remove-binary-blob-integrations.patch removing that could mean writing a glue without implementation between chromium and the google libraries, which would be a lot of work

@uazo uazo mentioned this issue Jul 22, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wip work in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@uazo