Enable all Eyeo Adblock Plus features

[marcinwiacek]

"old" Bromite was able to block ads in m.youtube.com on video start, with builds here enabling blocking in "AdBlock settings" is not enough, you need to enable "Ad blocking" with ABP filters (I tried also with all lists enabled in settings menu below ABP filters).

Problem: after enabling these filters and entering video in m.youtube.com with ads on beginning user see black screen instead of video... and video plays after few seconds (something even, when you change page to other m.youtube.com subpage), but... after refreshing page ad is not displayed and video can be immediately started (it works like expected).

I could say, this is problem of "ABP filters", but... old Bromite + other browsers are working in this situation (blocking ads correctly).

Can be smth done here?

tried 110 and 111, Android 10

[uazo]

are you telling me that

• with adblockplus enabled, the ad is not shown but a black block is shown while waiting for video
• with adblockplus disabled, the ad is not shown and the video appears immediately

Try again, however, all things being equal, i.e. with the browser closed and reopened and new anonymous browsing window.
let me know, if you can provide a video it's better

[marcinwiacek]

Hallo,
I'm sorry for describing it maybe incorrectly, thank you for your answer.
I'm looking for way for disabling ads in video in youtube.
Bromite with ad-blocker was OK - I haven't seen ads for months, now (I returned to it yesterday) I see some of them.
CHromium with old ad-blocker behaves the same -> doesn't block everything (it means, Chromium builds are not worse than Bromite)
Chromium with new ad-blocker needs enabling "ABP filters" -> with them after opening video list & clicking on video video is opened with black screen (when we have ad on beginning) and video playback starts after few seconds, but... when you just refresh the page, everything is perfect (we don't have ad and playback starts immediately).
For me it means, that "ABP filters" are maybe not enough, in the same time other browsers seems to work better (example: Vivaldi) -> it means, that maybe implementation of "new" adblocker with combination of other options is somehow problematic.
It would be good, if this target (blocking all video ads) could be somehow achieved with any list combination or any other way, additionally it would be good to see lists descriptions in "new" adblocker like in other browsers.
This "issue" is maybe not very important, but very welcome.
Thank you & I hope, it's more clear. Sorry for misunderstanding.

[uazo]

I'm looking for way for disabling ads in video in youtube.

that adblock patch is still in work in progress.
as far as i'm concerned i don't particularly care about blocking youtube video ads, but i know that adblock plus would be able to do it if i enabled anti-circumvention rules which are currently disabled in the code.
I have already set myself the task of verifying the activation of that functionality, but it is not a priority. The issue is that in order to work it the adblock injects javascript code which I have not yet verified, and in fact I am disinclined to allow it.
we will talk again

[marcinwiacek]

I know this project is not commercial + there are maybe much more interesting features, from the other hand - is it possible to do something here, please?

Full blocking functionalities help a lot in faster opening pages, allow for better watching youtube and help in many things.

[uazo]

(in v113)

I probably need to force the subscription update:

[20216:1240:0502/093303.940:INFO:subscription_validator_impl.cc(52)] [eyeo] Schema version
has changed, invalidating stored subscriptions.

is it possible to do something here, please?

@marcinwiacek certainly, it's in my activity queue.

[uazo]

see #165 (comment)

[uazo]

From bromite/bromite#2359 (comment)_

• the code allows modification of the response headers
  clarify which ones and if only blocking is possible
• the code allows the modification of the csp
  clarify which ones and if only blocking is possible
• the code allows the url rewrite (but seems only to internal resources)
  however to be verified
• understand if any error in "elemhide_for_selector.jst" not currently trapped with try / catch can arrive at the page as window.onerror
• check if we are actually blocking the snippets, which being injected js code decided by external filters may not be suitable for bromite
• understand why in the generation of the css string (in js emulation) the url is also injected.
• the code predicts that localhost is never blocked but it is to check if the calls to localhost are already blocked by bromite
• the code "installs" a proxy in the UrlLoaders, check the functionality better
• there is some sort of metadata in the subscription file (https://eyeo.gitlab.io/adblockplus/abc/core-spec/#appendix-filter-list-syntax), understand what it is for
• check better what the "sitekeys" and the "special filters" are
• css injection seems to block the BackForwardCache
• check converter.cc, if any rule is not suitable for bromite
• check for redirect_info.bypass_redirect_checks

[uazo]

fixed in uazo/cromite@5ffb665 and in uazo/cromite@a0874d0

[uazo]

in uazo/cromite@af55aa0

• removed support for header and csp filter option
• removed support for json-override, simulate-event-poc, simulate-mouse-event snippets
• allowed the use of override-property-read by eliminating the possibility of specifying a number as an argument (except 0 and 1)

[buawf]

@uazo

What filters are enabled by default in ABP ?

[uazo]

the code is to activate the lists according to the language set in the device.
lists are defined in
https://raw.githubusercontent.com/uazo/cromite/master/build/patches/eyeo-beta-118.0.5993.48-base.patch
look for static std::vector<KnownSubscriptionInfo> recommendations = {

please note that that is the original code, and these are my modifications
https://github.com/uazo/cromite/blob/master/build/patches/Eyeo-Adblock-for-Cromite.patch#L4986-L5022