Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitioning cookies in WebView breaks app login state #1490

Open
4 tasks done
skbeh opened this issue Sep 21, 2024 · 4 comments
Open
4 tasks done

Partitioning cookies in WebView breaks app login state #1490

skbeh opened this issue Sep 21, 2024 · 4 comments
Labels

Comments

@skbeh
Copy link

skbeh commented Sep 21, 2024

Preliminary checklist

  • I have read the README.
  • I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
  • I have updated Cromite to the latest version. The bug is reproducible on this latest version.
  • This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else.

Can the bug be reproduced with corresponding Chromium version?

No

Are you sure?

No

Cromite version

129.0.6668.59

Device architecture

arm64

Platform version

Android 14

Android Device model

Android

Is the device rooted?

Yes

Changed flags

no flags changed

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

No

Describe the bug

After changing the system WebView to Cromite WebView, I find that I am logged out of a specific app used in my organization every time I restart it.

However, after reverting the build/patches/Partitioning-all-cookies-by-top-frame-domain.patch, the issue was resolved. This suggests that it may be beneficial to either disable cookie partitioning in WebView or offer an option to turn it off.

Additionally, changing the disable-partitioned-cookies flag and ThirdPartyStoragePartitioning flag does not affect the issue.

Steps to reproduce the bug

  1. Set the system WebView to Cromite WebView.
  2. Log in to the app.
  3. Force stop the app.
  4. Relaunch the app.
  5. Note the "invalid login state" error and that you are logged out

Expected behavior

The login state is persisted.

Screenshots

No response

@uazo
Copy link
Owner

uazo commented Sep 21, 2024

What app do you use to test it?

@skbeh
Copy link
Author

skbeh commented Sep 21, 2024

It's an app used in my organization, so it is not publicly available.

@uazo
Copy link
Owner

uazo commented Sep 26, 2024

Let me get this straight, what is the point of installing an alternative webview for use by a business application? Can you make me understand the motivation?

@skbeh
Copy link
Author

skbeh commented Sep 26, 2024

Cromite WebView is set to the global WebView on my personal device, not specifically for this app. Alternative webview should not break apps, and the cookies partitioning feature is known to break many websites.

@uazo uazo added the webview label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants