Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone customization: Crash when adding site exception #218

Closed
5 tasks done
t-m-w opened this issue Aug 24, 2023 · 1 comment
Closed
5 tasks done

Timezone customization: Crash when adding site exception #218

t-m-w opened this issue Aug 24, 2023 · 1 comment
Labels
bug Something isn't working reproducible Tried it, it's true

Comments

@t-m-w
Copy link

t-m-w commented Aug 24, 2023

Preliminary checklist

  • I have read the README.
  • I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
  • I have read the FAQs.
  • I have updated Cromite to the latest version. The bug is reproducible on this latest version.
  • This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else.

Can the bug be reproduced with corresponding Chromium version?

Yes

Cromite version

version 116.0.5845.111

Device architecture

arm64-v8a

Android version

13

Device model

Pixel 6 Pro

Changed flags

no flags changed

Is this bug happening in an incognito tab?

No

Is this bug caused by the adblocker?

No

Is this bug a crash?

Yes, but I can't upload it now; quickly reporting from mobile, and this refuses to accept any file to upload

Describe the bug

Cromite crashes when adding a site exception for Timezone customization

Steps to reproduce the bug

  1. Open Cromite's settings
  2. Go to Site settings
  3. Go to Timezone customization
  4. Tap Add exception
  5. Enter e.g. github.com and tap Add

Expected behavior

Site exception is added

Screenshots

No response

@uazo
Copy link
Owner

uazo commented Aug 25, 2023

crash log:

java.lang.ClassCastException: org.chromium.components.browser_ui.site_settings.TimezoneOverrideSiteSettingsPreference cannot be cast to org.chromium.components.browser_ui.site_settings.TriStateSiteSettingsPreference
	at org.chromium.components.browser_ui.site_settings.SingleCategorySettings.isBlocked(SingleCategorySettings.java:1104)
       	at org.chromium.components.browser_ui.site_settings.SingleCategorySettings.addWebsites(SingleCategorySettings.java:1032)
	at org.chromium.components.browser_ui.site_settings.SingleCategorySettings.-$$Nest$maddWebsites(Unknown Source:0)
	at org.chromium.components.browser_ui.site_settings.SingleCategorySettings$ResultsPopulator.onWebsitePermissionsAvailable(SingleCategorySettings.java:238)
	at org.chromium.components.browser_ui.site_settings.WebsitePermissionsFetcher$WebsitePermissionFetcherInternal$PermissionsAvailableCallbackRunner.run(WebsitePermissionsFetcher.java:582)
	at org.chromium.components.browser_ui.site_settings.WebsitePermissionsFetcher$WebsitePermissionFetcherInternal$Task.runAsync(WebsitePermissionsFetcher.java:385)
	at org.chromium.components.browser_ui.site_settings.WebsitePermissionsFetcher$WebsitePermissionFetcherInternal$TaskQueue.next(WebsitePermissionsFetcher.java:396)
	at org.chromium.components.browser_ui.site_settings.WebsitePermissionsFetcher$WebsitePermissionFetcherInternal$Task.runAsync(WebsitePermissionsFetcher.java:386)
	at org.chromium.components.browser_ui.site_settings.WebsitePermissionsFetcher$WebsitePermissionFetcherInternal$TaskQueue.next(WebsitePermissionsFetcher.java:396)
	at org.chromium.components.browser_ui.site_settings.WebsitePermissionsFetcher$WebsitePermissionFetcherInternal.fetchPreferencesForCategory(WebsitePermissionsFetcher.java:230)
	at org.chromium.components.browser_ui.site_settings.WebsitePermissionsFetcher.fetchPreferencesForCategory(WebsitePermissionsFetcher.java:163)
	at org.chromium.components.browser_ui.site_settings.SingleCategorySettings.getInfoForOrigins(SingleCategorySettings.java:295)
	at org.chromium.components.browser_ui.site_settings.SingleCategorySettings.onAddSite(SingleCategorySettings.java:877)
	at org.chromium.components.browser_ui.site_settings.AddExceptionPreference$1.onClick(AddExceptionPreference.java:158)
	at androidx.appcompat.app.AlertController$ButtonHandler.handleMessage(AlertController.java:167)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7839)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reproducible Tried it, it's true
Projects
None yet
Development

No branches or pull requests

2 participants