Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

116.0.5845.163: new chromium version #245

Closed
github-actions bot opened this issue Aug 30, 2023 · 10 comments
Closed

116.0.5845.163: new chromium version #245

github-actions bot opened this issue Aug 30, 2023 · 10 comments
Labels
release They mark releases (if I remember to put it on :)

Comments

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

found:

@uazo
Copy link
Owner

uazo commented Aug 31, 2023

commit: 3fede7c
builder: https://github.com/uazo/cromite/actions/runs/6021986388
release: https://github.com/uazo/cromite/releases/tag/v116.0.5845.163-3fede7c3fd9855719355e893e827b82e252d3a19
docker image: uazo/cromite-build:116.0.5845.163-3fede7c3fd9855719355e893e827b82e252d3a19

changes;

  • Bump to 116.0.5845.163

@althafvly
Copy link

@uazo https://github.com/uazo/cromite/blob/master/build/patches/00do-not-block-build-incompatible-profiles.patch this patch seems to be failing while patching.

Applying: Do not block the build for incompatible profiles
error: sha1 information is lacking or useless (.gitignore).
error: could not build fake ancestor
Patch failed at 0001 Do not block the build for incompatible profiles
hint: Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@uazo
Copy link
Owner

uazo commented Aug 31, 2023

this patch seems to be failing while patching.

you are probably missing this:

https://github.com/uazo/cromite/blob/master/tools/images/bromite-source/apply-bromite-patches.sh#L10

since I am modifying v8, I need to remove the submodule.

@macchrome
Copy link

I'd like to draw your attention to this problem:

crash opening site settings window in 116.0.5845.141

macchrome/winchrome#110

@uazo
Copy link
Owner

uazo commented Sep 2, 2023

crash opening site settings window in 116.0.5845.141

unfortunately I saw. thank you for telling me.

@uazo

This comment was marked as off-topic.

@uazo

This comment was marked as off-topic.

@macchrome

This comment was marked as off-topic.

@uazo

This comment was marked as off-topic.

@uazo
Copy link
Owner

uazo commented Sep 6, 2023

next version #269

@uazo uazo closed this as completed Sep 6, 2023
@uazo uazo unpinned this issue Sep 6, 2023
@uazo uazo added the release They mark releases (if I remember to put it on :) label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release They mark releases (if I remember to put it on :)
Projects
None yet
Development

No branches or pull requests

3 participants