Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .htaccess files #105

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Conversation

jtpalmer
Copy link
Contributor

Description

Removes all .htaccess files along with .htaccess_maintenance, .htaccess_pass and .htaccess_production files.

Motivation and Context

Several of these files contain references to the ccr.buffalo.edu domain and port numbers that are used at CCR. There is no reason for them to be included here.

The current Open XDMoD configuration instructions do not use .htaccess. All the mod_rewrite rules are defined directly in the Apache configuration.

Tests performed

Installed Open XDMoD without .htaccess files.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added this to the v7.0.0 milestone Apr 20, 2017
@jpwhite4
Copy link
Member

What ever happened to the "enable maintenance mode" ability? I thought it used these htaccess files to disable access.

@jtpalmer jtpalmer requested a review from jpwhite4 April 21, 2017 12:01
@jtpalmer
Copy link
Contributor Author

Some of our internal documentation still references set_portal_mode, but I can't find that script anywhere. We can move these files to the XSEDE repository if necessary.

@jtpalmer jtpalmer merged commit 4070a93 into ubccr:xdmod7.0 Apr 21, 2017
@jtpalmer jtpalmer deleted the remove-htaccess-files branch April 24, 2017 18:01
@tyearke tyearke added the qa label May 10, 2017
@plessbd plessbd added the qa / testing Updates/additions to tests label Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa / testing Updates/additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants