Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back Porting 6.7 Metric Explorer fix to 6.6 #119

Merged
merged 1 commit into from
May 1, 2017
Merged

Back Porting 6.7 Metric Explorer fix to 6.6 #119

merged 1 commit into from
May 1, 2017

Conversation

ryanrath
Copy link
Contributor

@ryanrath ryanrath commented May 1, 2017

Description

  • Back porting fix for NavKey handlers being executed for non-NavKey key presses.

Motivation and Context

Making sure that this fix gets into 6.6 as well as 6.7

Tests performed

  • Manual Testing
  • Automated Test added to xsede/tests/automated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ryanrath
Back Porting 6.7 Metric Explorer fix to 6.6
5b85fd1 
- Fix for NavKey handlers being executed for non-NavKey key presses.
@ryanrath ryanrath merged commit c2df8e8 into ubccr:xdmod6.6 May 1, 2017
@ryanrath ryanrath deleted the metric_explorer_left_key branch May 1, 2017 14:37
@tyearke tyearke mentioned this pull request May 4, 2017
Merged
tyearke added a commit that referenced this pull request May 4, 2017
@tyearke
Merge pull request #126 from ubccr/xdmod6.6
9cf6a59 
Merge #98, #102, #103, #108, #113, #115, #119, #121 into 6.7
@tyearke tyearke mentioned this pull request May 4, 2017
Merged
tyearke added a commit that referenced this pull request May 5, 2017
@tyearke
Merge pull request #127 from tyearke/merges/6.7-2017-05-04
e214bb0 
Merge #98, #100, #101, #102, #103, #104, #107, #108, #113, #114, #115, #118, #119, #121, #122, #126 into 7.0
@tyearke tyearke added this to the v6.6.0 milestone May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

Assignees
No one assigned
Labels
bug Bugfixes version sync
Projects
None yet
Milestone
v6.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanrath @plessbd @tyearke