Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for a pre-release build configuration option. The pre-release tag is used for versioning of alpha/beta/release candidate packages.
Comments have also been added to the
OpenXdmod\Build\Config
class.Motivation and Context
Version/release numbers generated by our current process result in incorrectly versioned RPM packages. e.g.:
For the configuration:
Results in:
The proper CentOS 6 RPM name is: xdmod-5.6.0-0.1.rc1.el6.noarch.rpm (note that 0.1 is defore rc1)
Moving "rc1" into the "release" portion of the configuration would fix the RPM, but then it is not used as part of the tarball (since that is not intended to be used as part of the tarball name).
This is an issue because it breaks the RPM upgrade process. The release portion of the versions must be sortable.
The new process would use these values:
And gives the desired results:
Refer to:
Tests performed
Built packages with and without the pre-release configuration being used. Compared generated RPM spec files and the other contents of the tarballs.
Types of changes
Checklist: