Resolving issue with tests not running on *nix/Firefox #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There was an issue running the tests under *nix / Firefox that occurred due to Firefox not switching back to the default frame context which lead any further tests to fail ( as it would not be able to locate anything ).
- Travis doesn't like our classes, specifying that it should use node and es6.
plessbd
approved these changes
Jul 20, 2017
jtpalmer
pushed a commit
to jtpalmer/xdmod
that referenced
this pull request
Jul 24, 2017
* Resolving issue with tests not running on *nix/Firefox - There was an issue running the tests under *nix / Firefox that occurred due to Firefox not switching back to the default frame context which lead any further tests to fail ( as it would not be able to locate anything ). * Adding to fix Travis - Travis doesn't like our classes, specifying that it should use node and es6.
ryanrath
added a commit
to ryanrath/xdmod
that referenced
this pull request
Jul 24, 2017
* Resolving issue with tests not running on *nix/Firefox - There was an issue running the tests under *nix / Firefox that occurred due to Firefox not switching back to the default frame context which lead any further tests to fail ( as it would not be able to locate anything ). * Adding to fix Travis - Travis doesn't like our classes, specifying that it should use node and es6.
chakrabortyr
pushed a commit
to chakrabortyr/xdmod
that referenced
this pull request
Oct 17, 2017
* Resolving issue with tests not running on *nix/Firefox - There was an issue running the tests under *nix / Firefox that occurred due to Firefox not switching back to the default frame context which lead any further tests to fail ( as it would not be able to locate anything ). * Adding to fix Travis - Travis doesn't like our classes, specifying that it should use node and es6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firefox not switching back to the default frame context which lead any further
tests to fail ( as it would not be able to locate anything ).
Motivation and Context
Because tests would not run on *nix / Firefox
Tests performed
Ran full test suite under Firefox / Chrome
Types of changes
Checklist: