Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Ext.ajax API call correctly. #236

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Conversation

jpwhite4
Copy link
Member

Description

The existing code used the half-baked CCR.encode function to try to
encode data for a rest call. This change uses the ExtJS library function
that encodes the parameters correctly.

Motivation and Context

Bug fix

Tests performed

Steps to reproduce / verify:

  1. Create metric explorer chart with a '#' symbol in the chart title; Add some supremm data
  2. Click show raw data in the chart; Click on a job in the "raw data" window and confirm that job viewer loads and has a search node with the aforementioned chart title.
  3. Go back to the metric explorer and click on another job.
  4. Confirm that the job viewer loads again and the second job appears under the same tree node as the first one (the buggy code would incorrectly create a duplicate search node).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

The existing code used the half-baked CCR.encode function to try to
encode data for a rest call. This change uses the ExtJS library function
that encodes the parameters correctly.
@jpwhite4 jpwhite4 merged commit 3cc69f5 into ubccr:xdmod7.0 Sep 18, 2017
@jpwhite4 jpwhite4 deleted the uriencode branch September 18, 2017 14:01
@tyearke tyearke added this to the v7.0.0 milestone Sep 21, 2017
@tyearke tyearke mentioned this pull request Sep 21, 2017
@tyearke tyearke added the bug Bugfixes label Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants