Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.3.3 fix for DirectoryIterator::getExtension #269

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

ryanrath
Copy link
Contributor

  • DirectorIterator::getExtension did not exist until PHP 5.3.6

Description

The DirectoryIterator::getExtension method was not added until 5.3.6, this causes an issue when used on CentOS6 systems that install 5.3.3 by default.

Motivation and Context

The code does not execute on CentOS6 & PHP 5.3.3. This modification should resolve that

Tests performed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- DirectorIterator::getExtension did not exist until PHP 5.3.6
@jtpalmer jtpalmer added this to the v7.0.1 milestone Sep 27, 2017
@jtpalmer jtpalmer added the bug Bugfixes label Sep 27, 2017
@jtpalmer jtpalmer changed the base branch from xdmod7.1 to xdmod7.0 September 27, 2017 16:48
@jtpalmer jtpalmer merged commit 3770204 into ubccr:xdmod7.0 Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants