Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules to exclude restrictions on control structure indentation. #28

Merged
merged 2 commits into from
Jan 17, 2017

Conversation

jpwhite4
Copy link
Member

Relax the phpcs rules so that it does not disallow perfectly reasonably indented code.

Motivation and Context

Forcing a clurly brace on one line vs the next does not result in a big improvement to the code quality, but it does result in a onerous burden on the developers. This change relaxes these types of rules.

Tests performed

Ran phpcs on the code with the new ruleset.

@jpwhite4 jpwhite4 requested a review from smgallo January 17, 2017 19:10
Copy link
Contributor

@smgallo smgallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable set of rules and removes all of the annoying checks that don't add anything of value. I ran it on several directories of my code with good results.

@smgallo
Copy link
Contributor

smgallo commented Jan 17, 2017

The only error that I still saw was CamelCase, because I prefix interface class names with "i" and abstract class names with "a" to they are not confused with concrete classes. For example iDataEndpoint and aOptions.

@jpwhite4 jpwhite4 merged commit 08c2dea into ubccr:xdmod6.6 Jan 17, 2017
@jpwhite4 jpwhite4 deleted the update_rules branch January 17, 2017 21:40
@tyearke tyearke added the qa label Jan 18, 2017
@tyearke tyearke added this to the v6.6.0 milestone Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants