Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ETL JSON data endpoint filter logging #29

Merged
merged 2 commits into from
Jan 19, 2017

Conversation

smgallo
Copy link
Contributor

@smgallo smgallo commented Jan 19, 2017

Wrap JSON ETL DataEndpoint filter execution in try/catch block for improved error logging.

Description

Wrap JSON ETL DataEndpoint filter execution in try/catch block for improved error logging. Also fix phpcs warnings.

Motivation and Context

Improved logging

Tests performed

Provided the patch to IU for testing on their system.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@smgallo smgallo added the enhancement Enhancement of the functionality of an existing feature label Jan 19, 2017
@smgallo smgallo added this to the v6.6.0 milestone Jan 19, 2017
@smgallo smgallo requested a review from tyearke January 19, 2017 18:05
@smgallo smgallo merged commit fd58879 into ubccr:xdmod6.6 Jan 19, 2017
@smgallo smgallo deleted the etl/improve-jsonfile-logging branch January 19, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants