-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change staging table to use 1 as unknown id instead of -1 #866
Change staging table to use 1 as unknown id instead of -1 #866
Conversation
Did the pre-populated table data change too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the prepopulated data for these tables that have 'Unknown' hardcoded? I can't see it in the repo.
[edit] I see that it is set in the initialize_unknown_dimension_values action
In the docs/cloud.md is says to run
But I think that the jobs-cloud-common must be run after the ingest-resources otherwise the 'unknown' rows will not be populated properly. |
Need to update the comment for account_id column in configuration/etl/etl_tables.d/cloud_common/account.json |
Should not set the default person_id to 1 in configuration/etl/etl_tables.d/cloud_common/instance.json |
The comment on the modw_cloud.region.region_id column states
yet this table is populated with an 'unknown' row by the initialize_unknown_dimension_values.json. Which is correct? |
For columns in the cloud staging tables related to the changes in #861 change the COALESCE statements to use 1 instead of -1.
Tests performed
Ran all tests in docker
Types of changes
Checklist: