Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobs cloud common pipeline to cloud ingestor #916

Merged

Conversation

eiffel777
Copy link
Contributor

@eiffel777 eiffel777 commented May 3, 2019

This PR does two things. It add the jobs-cloud-common pipeline to cloud ingestor to prevent errors from occurring during ingestion when the cloud realm is enabled but no cloud data has been shredded. It also adds debug messages to the functions is DatawarehouseInitializer.php that run ingestion and aggregation pipelines when checking to see if the realm they are ingesting data for is enabled.

Tests performed

Manually tested in docker and ran tests in docker as well.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…. adding jobs-cloud-common pipeline to cloud ingestor functions
@eiffel777 eiffel777 added bug Bugfixes Category:ETL Extract Transform Load Category:Cloud Cloud Realm autodoc:ignore Auto documentation ignore this PR labels May 3, 2019
@eiffel777 eiffel777 added this to the 8.1.2 milestone May 3, 2019
@eiffel777 eiffel777 self-assigned this May 3, 2019
Copy link
Contributor

@chakrabortyr chakrabortyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's update the description of the PR to make what it's doing more explicit for other reviewers.

@eiffel777 eiffel777 merged commit e697a5c into ubccr:xdmod8.1 May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodoc:ignore Auto documentation ignore this PR bug Bugfixes Category:Cloud Cloud Realm Category:ETL Extract Transform Load
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants